-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-13378 build: Temporarily pin libfabric to < 1.18 #12119
Conversation
Required-githooks: true Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Required-githooks: true Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage NLT on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12119/4/testReport/(root)/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12119/5/execution/node/1162/log |
How temporary is this expected to be? Just for clarity, once again, I will re-iterate that setting maximum dependency versions will severely hamper our future ability to push out an update to a component/dependency in an agile manner, and instead of just being able to push out an update (without any DAOS release -- including full testing, QA, SDL, etc.) to the component, we will need to update DAOS, do all required testing on it and re-qualify it with SDL before users can have a libfabric update. We really really need to strive to never use maximum dependency versions, especially in a released product. If this will be reverted before any release is made, we can live with it, but we must make sure to remember to not make any release with this change in it. |
I agree, yes we're working on the issue currently and that restriction should be lifted before release. |
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: