Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-12601 mercury: disable multi-recv except for prov/cxi #11947

Merged
merged 3 commits into from
Apr 20, 2023
Merged

DAOS-12601 mercury: disable multi-recv except for prov/cxi #11947

merged 3 commits into from
Apr 20, 2023

Conversation

soumagne
Copy link
Collaborator

In preparation of mercury update to 2.3.0

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@soumagne
DAOS-12601 mercury: disable multi-recv except for prov/cxi
2c991fd 
In preparation of mercury update to 2.3.0

Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne requested a review from frostedcmos April 13, 2023 18:55
@github-actions
Copy link

github-actions bot commented Apr 13, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'Update mercury to 2.3.0'
Status is 'In Review'
Job should run at elevated priority (3)
https://daosio.atlassian.net/browse/DAOS-12601

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Apr 13, 2023
daosbuild1
daosbuild1 reviewed Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne soumagne mentioned this pull request Apr 14, 2023
Merged
daosbuild1
daosbuild1 reviewed Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-11947/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-11947/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-11947/2/display/redirect

@soumagne soumagne requested a review from a team April 19, 2023 16:49
daosbuild1
daosbuild1 reviewed Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne soumagne added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 19, 2023
@soumagne
Copy link
Collaborator Author

This PR is adding an environment variable that is not affecting any of the current builds, as it will be used by future rpm update of mercury

@frostedcmos frostedcmos merged commit f8318c8 into master Apr 20, 2023
@frostedcmos frostedcmos deleted the soumagne/disable_multi_recv_master branch April 20, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@frostedcmos frostedcmos frostedcmos approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumagne @daosbuild1 @jolivier23 @frostedcmos