DAOS-16465 vos: fix misused ip_hdl (#15034) (#15043)

vos_iter_param_t.ip_hdl is for passing dkey or akey tree open handle
in vos_iterate_key() case, don't always regard it as 'vos_pool' or
'vos_container'.

Signed-off-by: Niu Yawei <yawei.niu@intel.com>

src/include/daos_srv/vos_types.h

@@ -413,7 +413,9 @@ typedef int (*vos_iter_filter_cb_t)(daos_handle_t ih, vos_iter_desc_t *desc,
  * Parameters for initializing VOS iterator
  */
 typedef struct {
-	/** pool connection handle or container open handle */
+	/** pool connection handle or container open handle,
+	 *  for vos_iterate_key(), it's used for passing dkey or akey tree open handle.
+	 */
 	daos_handle_t		ip_hdl;
 	/** standalone prepare:	DAOS_HDL_INVAL
 	 *  nested prepare:	parent iterator handle

src/vos/vos_iterator.c

@@ -148,6 +148,11 @@ is_sysdb_pool(vos_iter_type_t type, vos_iter_param_t *param)
 	struct vos_pool		*vos_pool;
 	struct vos_container	*vos_cont;
 
+	/* vos_iterate_key() will never be called upon sysdb */
+	if (param->ip_flags == VOS_IT_KEY_TREE)
+		return false;
+
+	D_ASSERT(!(param->ip_flags & VOS_IT_KEY_TREE));
 	if (type == VOS_ITER_COUUID) {
 		vos_pool = vos_hdl2pool(param->ip_hdl);
 		D_ASSERT(vos_pool != NULL);

src/vos/vos_obj.c

@@ -1689,16 +1689,23 @@ vos_obj_iter_prep(vos_iter_type_t type, vos_iter_param_t *param,
 		  struct vos_ts_set *ts_set)
 {
 	struct vos_obj_iter	*oiter;
-	struct vos_container	*cont = vos_hdl2cont(param->ip_hdl);
-	bool			 is_sysdb = cont->vc_pool->vp_sysdb;
-	struct dtx_handle	*dth = vos_dth_get(is_sysdb);
+	struct vos_container	*cont = NULL;
+	bool			 is_sysdb = false;
+	struct dtx_handle	*dth = NULL;
 	daos_epoch_t		 bound;
 	int			 rc;
 
 	D_ALLOC_PTR(oiter);
 	if (oiter == NULL)
 		return -DER_NOMEM;
 
+	/* ip_hdl is dkey or akey tree open handle for vos_iterate_key() */
+	if (!(param->ip_flags & VOS_IT_KEY_TREE)) {
+		cont = vos_hdl2cont(param->ip_hdl);
+		is_sysdb = cont->vc_pool->vp_sysdb;
+		dth = vos_dth_get(is_sysdb);
+	}
+
 	bound = dtx_is_valid_handle(dth) ? dth->dth_epoch_bound :
 		param->ip_epr.epr_hi;
 	oiter->it_iter.it_bound = MAX(bound, param->ip_epr.epr_hi);