Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

Update dependency Result to non-beta version #30

Merged
merged 6 commits into from
Dec 16, 2015

Conversation

danthorpe
Copy link
Owner

In this file: https://github.com/danthorpe/Money/blob/development/Money.podspec, it shows a dependency:

s.dependency 'Result', '0.6.0-beta.6'

The beta version number causes a CFBundleVersion error when uploading to iTunes, as per this Stackoverflow thread: http://stackoverflow.com/a/33375436/4769084

My interim solution was to manually update the info.plist file of the pod, however using a non-beta dependency would probably be better.

@danthorpe danthorpe added the bug label Dec 16, 2015
@danthorpe
Copy link
Owner

Sorry about that @mrdavey - hadn't noticed that Result was finally out of beta - will fix it very now.

@hsoi
Copy link

hsoi commented Dec 16, 2015

How funny. I just ran into this exact same problem myself and was coming here to file an issue on it. 😸

Thank you for the speedy turnaround, @danthorpe

@danthorpe
Copy link
Owner

@hsoi - yeah, just sorting out a bitcode / watchOS / Carthage / Xcode 7.2 situation.... should be sorted very soon.

@mrdavey
Copy link
Author

mrdavey commented Dec 16, 2015

Thank you @danthorpe !

@hsoi
Copy link

hsoi commented Dec 16, 2015

No worries @danthorpe ! I'm taking @mrdavey 's same approach and just hacking the Info.plist of Result so I can build and submit (gotta get it submitted this morning).

But to have this properly sorted out will be good for post-release 👍

Thanx again!

@danthorpe danthorpe changed the title podspec file needs updated dependencies Update dependency Result to non-beta version Dec 16, 2015
@codecov-io
Copy link

Current coverage is 0.00%

Merging #30 into development will decrease coverage by -100.00% as of 85ffb73

No diff could be generated. No reports for #30 found.
Review entire Coverage Diff as of 85ffb73

Powered by Codecov. Updated on successful CI builds.

@danthorpe
Copy link
Owner

@mrdavey @hsoi - okay, sounds good - being practical. I knew that -beta6 was going to be a problem eventually... Also great that you're submitting apps with Money! (I've not actually got round to it myself yet!) 👍

danthorpe added a commit that referenced this pull request Dec 16, 2015
Update dependency Result to non-beta version
@danthorpe danthorpe merged commit ef8475e into development Dec 16, 2015
@danthorpe
Copy link
Owner

Pushed 1.4.2 to CocoaPods 😀

@hsoi
Copy link

hsoi commented Dec 17, 2015

@danthorpe thank you! Got it updated and things seem good.

Yup. Just submitted an app using Money ScoreSense Scores To Go, the 2.0 version will be using it. Helped me with some parsing and display stuff. 👍

Thanx for it!

@danthorpe danthorpe deleted the feature/MNY-30_result_dependency branch February 6, 2016 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants