Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

Post 1.0.0 issues #16

Merged
merged 6 commits into from
Nov 6, 2015
Merged

Post 1.0.0 issues #16

merged 6 commits into from
Nov 6, 2015

Conversation

danthorpe
Copy link
Owner

  • Remove the documentation coverage badge? CocoaDocs still doesn't seem to be working, I think an underlying issue with Jazzy - as I can't generate them locally either.

  • There are some incorrectly named unit test functions which might be confusing, especially in the FX stuff.

  • Spelling errors in the README.

  • Would make sense to provide access to FXQuote and for it to conform to NSCoding. e.g. something like

    Yahoo<USD,EUR>.quote(100) { result in
        if let quote, euros = result.value {
            // have access to the quote and the euros.
        } 
     }

@codecov-io
Copy link

Current coverage is 100.00%

Merging #16 into development will not affect coverage as of 728fd9e

@@            development     #16   diff @@
===========================================
  Files                 8       8       
  Stmts               457     466     +9
  Branches              0       0       
  Methods                               
===========================================
+ Hit                 457     466     +9
  Partial               0       0       
  Missed                0       0       

Review entire Coverage Diff as of 728fd9e

Powered by Codecov. Updated on successful CI builds.

danthorpe added a commit that referenced this pull request Nov 6, 2015
@danthorpe danthorpe merged commit 1301f4e into development Nov 6, 2015
@danthorpe danthorpe deleted the feature/MNY-16_post_1.0_fixes branch November 7, 2015 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants