-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PKCE] Enable For Code Grant #61
base: master
Are you sure you want to change the base?
Conversation
…a scope param is indeed optional
@danschultzer Hi! If you have any thoughts about the direction of this code - let me know! Also - what version of elixir are you developing with. I have been using erlang 22.0 and elixir 1.9.1. It would be possible to run elixir-format however I know it will modify the whitespace that has been manually injected in certain areas - Is it tolerable for you to accept elixir-format based auto-format? Best, Curtis |
Hey, any plan on finishing/merging this? PKCE support would be great. |
@danschultzer please give the PR a look |
Good to know! I'll review this again, and get PKCE support in ASAP. |
@danschultzer, is there any update on this PR? Thanks! |
@danschultzer any updates here? |
@danschultzer I'd be great to have PKCE support, cheers! |
Work in Progress:
Goal : config can enable pkce for response_type:code.
TODO:
update schema.
persist code_challenge_method , code_challenge.
process code_verifier before token generation.