Support overriding config's command through CLI args #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerouanton
force-pushed
the
override-command
branch
from
ad06916 to
9799cd9
Compare
akerouanton
force-pushed
the
override-command
branch
2 times, most recently
from
786c5a5 to
01247df
Compare
Commit ab25958 added support for oneliners, but it marked the 'command' arg as conflicting with the 'config' arg. This prevents using a config file with `go run|test -exec`. Moreover, having a way to override the command defined in the config file gives an easy way to exec into a VM to manually debug a failing command. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
force-pushed
the
override-command
branch
from
01247df to
2880e84
Compare
|
Looks like if there are multiple targets in a config file and you also provide a command override via CLI, then all commands in the config will be overridden. I'm wondering if that makes sense. WDYT about only allowing it if there's a single target in the config after filtering? That seems like it'd be less ambiguous. |
I was assuming that the filter arg should always yield a single target. I'm not sure to see how it works when it yields multiple targets. I'll need to play a bit with it, but that seems like a fair point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ab25958 added support for oneliners, but it marked the 'command' arg as conflicting with the 'config' arg. This prevents using a config file with
go run|test -exec.Moreover, having a way to override the command defined in the config file gives an easy way to exec into a VM to manually debug a failing command.