Added support for using a custom QEMU binary #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/qemu.rs
Outdated
|
|
||
| let mut c = Command::new(format!("qemu-system-{}", target.arch)); | ||
| // |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rdelfin
force-pushed
the
custom-qemu-binary
branch
from
b1ef914 to
3a7ea09
Compare
danobi
reviewed
Oct 22, 2024
src/qemu.rs
Outdated
Comment on lines
662
to
676
| // Confirm QEMU exists first | ||
| if let Err(e) = Command::new(&program) | ||
| .arg("--help") | ||
| .stdout(Stdio::null()) | ||
| .stderr(Stdio::null()) | ||
| .spawn() | ||
| { | ||
| if let ErrorKind::NotFound = e.kind() { | ||
| return Err(e).context(format!( | ||
| "Did not find QEMU binary {program}. Make sure QEMU is installed" | ||
| )); | ||
| } else { | ||
| warn!("Failed to verify that qemu is installed due to error, continuing... {e}"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Mind pulling this out into a helper function? Just so the main logic in this function is a bit more compact
There was a problem hiding this comment.
Yep! Let me do that. I'll take a little bit to continue, I need to wait for a thumbs up from work about a couple things, but I'll get back to you
There was a problem hiding this comment.
Sorry for the delay. Lmk if this is what you meant
rdelfin
force-pushed
the
custom-qemu-binary
branch
from
3a7ea09 to
13c072c
Compare
rdelfin
force-pushed
the
custom-qemu-binary
branch
from
13c072c to
8749032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking into getting
vmtestto work on a RHEL 8 system. After some digging me and @javierhonduco did, we found that one of the issues is that RHEL's QEMU installation is substantially different from most other Linux distros, as it does not createqemu-system-*binaries, but instead has a binary in/usr/libexec/qemu-kvm. In order to further test, overriding the binary path used to find QEMU would be extremely helpful. This PR does that.Manual Testing
Ran this on a RHEL machine:
The former failed to launch QEMU (with a clearer error message than before), the latter failed to start after launching QEMU (RHEL 8 does not support 9p from what we were able to find).