[release] Build vmtest binary for aarch64 and s390x too #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build vmtest for x86_64, aarch64, and s390x. As a side effect, x86_64 does not need a x86_64 anymore to be compiled. Example release: https://github.com/chantra/danobi-vmtest/releases/tag/v1.0.0 Signed-off-by: Manu Bretelle <chantr4@gmail.com>
danobi
approved these changes
Jan 10, 2024
Because we install the $arch toolchain regardless of what the host architecture is. ex: if host is arm64, we will still run: for x86_64, resulting on cross-compiling vmtest for x86_64
Agreed, let me do this.... |
|
moved to a script. Fixed some potential issue (e.g do not install toolchain for the running platform). workflow run: https://github.com/chantra/danobi-vmtest/actions/runs/7479502764/job/20356831774 |
danobi
reviewed
Jan 11, 2024
chantra
commented
Jan 11, 2024
* Make the script default to x86_64,aarch64, and s390x. * Speed up toolchain installation by batching it in one command. * save targets using the architecture name emmited by `uname -m` instead of debian architecture name. Signed-off-by: Manu Bretelle <chantr4@gmail.com>
chantra
force-pushed
the
release_multiarch
branch
from
41e8467 to
c10a4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build vmtest for x86_64, aarch64, and s390x.
As a side effect, x86_64 does not need a x86_64 anymore to be compiled.
Example release: https://github.com/chantra/danobi-vmtest/releases/tag/v1.0.0