init: Set QEMU state dir/PID file path directly #102
Conversation
|
The error in the linked issue was: However, it should have never happened b/c of the dual: vmtest/src/init/init.sh.template Lines 56 to 58 in edd5141 and Note how the default pidfile location is controlled by vmtest's init.sh. Seems like your qemu-ga has a different default pidfile location. So I think a more reliable fix would be explicitly specify the pidfile location for qemu-ga. Maybe just pin it to vmtest/src/init/init.sh.template Line 102 in edd5141 |
|
Ah yeah I tried that before but there's other paths that need to be changed too - however since you think it's a reasonable fix I'll just try fixing those too... |
This fixes danobi#101 for me. I'm not sure why I didn't used to hit this, but on my host system /var/local/run is owned by a privilged user and has no global write perms, but is also the default where the qemu-ga build writes these files to. Fix is just to set it explicitly to the default that exists on other systems, which the init script is already set up to handle.
bjackman
force-pushed
the
var-local-run
branch
from
8a8737c to
c57cf53
Compare
|
Cool seems to work, the other paths are all covered by a single arg. The tests fail on my machine (also on master) so let's see if the pass in GHA... |
Just for the record, I had a look into this, issues are:
So nothing to fix in vmtest I think. |
danobi
changed the title
|
Thanks for taking a look! The CI is not my proudest work :P Maybe one day we'll make it reliably work locally. |
This fixes #101 for me.
I'm not sure why I didn't used to hit this. I think the actual issue is that /var/local/run is owned by a privilged user and has no global write perms on my host system.
My confidence is not very high that I really understand this system so please review with skepticism :)