-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add undercurl as a style #1758
Comments
it looks like both wezterm and kitty are using |
So it looks like underline and undercurl (and double underline) are mutually exclusive. That's actually good, because we want to be able to color the underline etc., which there's no way to do through the hrmmmm. hrmmmmmmmmmmm. for direct mode, it's trivial, since we just need a single current state, which we just pass through. |
Not relevant at the moment but for awareness Windows Terminal supports underline and double underline. There's also a request to get all the Kitty extended underlines supported including undercurl: microsoft/terminal#7228 |
sweet! i hope to be compiling on Windows very soon. does microsoft terminal run on anything but windows? if so, i can add support for it now. |
No, most of the VT support comes from the open console (aka conhost). Most of the code should be portable to Windows Terminal though. Also you'd need to use a different UI framework first or use something like Uno (I would be interested in seeing this particular Terminal become x-plat but MS can't support doing that, especially when there's still gaps in VT to fill still). Don't want to contaminate this issue further with anything unrelated. |
At least kitty and wezterm, and probably others, support undercurl. Add
NCSTYLE_UNDERCURL
and the necessary code to support it, where available.The text was updated successfully, but these errors were encountered: