- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable quadrants+sextants in wezterm #1715
Comments
@wez, just a heads up. i'm going to enable this in our heuristics section when i identify wezterm. i'm not yet enabling sextants, since wezterm is relying on the font for those (i seem to recall filing a bug on this, but can't for the life of me find it). quadrants look good, but sextants are ragged. as a result, if you start drawing your own sextant glyphs, we can pump that up to |
wez/wezterm#584 is our issue tracking perfect block drawing glyphs, with wez/wezterm#588 as a slow-moving-but-not-abandoned PR to implement them. |
you're my hero, ferris bueller |
While I'm in here, teach the font fallback code that it doesn't need to search for these glyphs when custom block glyphs are enabled. refs: dankamongmen/notcurses#1715 refs: #584 refs: #588
I added just the sextant block glyphs to the nightly build just now. I don't appear to have a font that has those glyphs, so I based this entirely off my one pass through page 3 of https://unicode.org/charts/PDF/U1FB00.pdf this evening. Let me know if it looks weird, or if you need the smooth mosaic glyphs too! |
i will test shortly, hot shit! |
running into a linking issue
but i think this is because i updated the submodules past where they are in upstream wezterm. doing a build in a fresh checkout. |
one little thing while i have you here, @wez : your half blocks don't appear to meet. see the circled glyphs: that lower half ought be rising to the same level where the upper half starts, or things will look weird. i assume you're drawing these yourself, rather than using the font? if so, it looks like the lower half needs to be raised, as opposed to the upper half truncated (i don't think the lower half is coming all the way up to the middle). |
i did a quick visual inspection of all your sextant glyphs, and they look correct. nice work! |
it looks like we can detect the wezterm version with its environment variables:
i'll be doing this in #1759, which is a dependency of this bug. |
re: halves not matching up, which codepoints are those; the ones in the |
|
alright, i've now got detection code that identifies WezTerm based off old wezterm in new wezterm in home, note |
* Rename `draw_quad` to `fill_rect` to better indicate what it is doing. * Switch the 1/8th block rendering to use `fill_rect` with math that is consistent with quad drawing to compute the bounds. refs: dankamongmen/notcurses#1715 (comment)
I just pushed a tweak to the half block rendering (really, all the 1/8th block rendering) |
looks great! |
hrmmm, i'm thinking you might have one sextant off. i see sufficiently many strange regions (look around Montevideo, Rio de Jianaro, Washington DC and all its dread statism, Pretoria, Addis Ababa, etc.) that my autism meter goes to 10. i'll look into this and let you know whether there are truly any malformed glyphs. |
found the bad glyph! pr incoming |
quadrants look pretty good (sextants are another story) in wezterm 20210502 (verified with
caps-rendered
). we don't have a match forwezterm
just yet, but we ought get one, and enable quadrants.The text was updated successfully, but these errors were encountered: