-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STL Loader #119
STL Loader #119
Conversation
Binary support added in now as well. |
Converted to draft for a little while, I've got an error in the example code or model. Just working that out now. |
Looks like it's reading files with EOL conversion somewhere, rather than just as straight binary. Just trying to find out where that's happening. |
dc46d8f
to
112f9ed
Compare
Woohoo, green! |
112f9ed
to
1ffd9fa
Compare
to save CPU and memory
I've optimised the loader so it combines vertices on the fly during load - this should be more CPU and memory efficient when loading (which I'm doing a lot). Incidentally, this loader code is now active in the latest release of Manyfold (https://manyfold.app), where I'm using it for checking for mesh holes. It's using my fork, in advance of this making it into an official Mittsu release. |
This PR adds a loader for STLs, currently ASCII encoding only. Binary support will be following shortly, either in this PR or a followup.
STL is a pretty simple format, so there's not a lot in the way of tests, but I've tried to cover what edge cases I can think of. STLs are always triangles, so there's no quad support like the OBJ loader has.
Part of #116