Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexappcontent): onItemPressed returns observable #2006

Merged
merged 1 commit into from
Dec 8, 2017

Conversation

NiklasMerz
Copy link
Contributor

Now onItemPressed will return an Observable. This should improve adding an event.

Inspired by the 3dTouch plugin function onHomeIconPressed.

@NiklasMerz NiklasMerz force-pushed the indexappcontent-fix branch 2 times, most recently from 05962d2 to 79562b4 Compare October 4, 2017 18:32
@ihadeed
Copy link
Collaborator

ihadeed commented Oct 6, 2017

You can use the @CordovaFunctionOverride decorator. See example: https://github.com/ionic-team/ionic-native/blob/00c0707dad4fc98974ae2e8c3d720c7a7521e968/src/%40ionic-native/plugins/geofence/index.ts#L98

Sorry the decorator is not documented yet!

@NiklasMerz
Copy link
Contributor Author

NiklasMerz commented Oct 7, 2017

I have changed this to the @CordovaFunctionOverride(). Can I help documenting this decorator?

@NiklasMerz
Copy link
Contributor Author

NiklasMerz commented Oct 9, 2017

Is the the @CordovaFunctionOverride decorator working? I have some problems with it?

see also #2028 #2029

@ihadeed ihadeed merged commit 9a52110 into danielsogl:master Dec 8, 2017
@ihadeed
Copy link
Collaborator

ihadeed commented Dec 8, 2017

@NiklasMerz it should be working, yes. I will test it soon and apply any fixes if necessary.

@NiklasMerz
Copy link
Contributor Author

@ihadeed I have some trouble with the latest change. I get warnings on the console that the onitemPressed function is not avaivalble. Do you know how the get the decorator working in this scenario?

@ihadeed
Copy link
Collaborator

ihadeed commented Dec 11, 2017

@NiklasMerz Found the issue, just pushed a commit to fix it. Update to the latest @ionic-native/core and it should be resolved. (Publishing it now, should be live in a few minutes)

@NiklasMerz
Copy link
Contributor Author

Thank you @ihadeed. This fixed the issue for me, too.

@NiklasMerz NiklasMerz deleted the indexappcontent-fix branch June 25, 2018 07:05
@NiklasMerz NiklasMerz restored the indexappcontent-fix branch June 25, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants