Fix: Google Maps Doc page

[wf9a5m75]

No description provided.

[wf9a5m75]

@ihadeed Could you update the plugin?

And how to install the @ionic-native/googlemaps plugin from local.
Since I can not install the plugin from local, I can not test the code.

[ihadeed]

@wf9a5m75

I'll take a look and publish it soon.

To install locally, you can run npm run build google-maps in the root directory of ionic-native. Then copy dist/google-maps directory and use it instead of the old node_modules/@ionic-native/google-maps in your Ionic app.

You can also use npm link but I'm not quite sure how that works.

[wf9a5m75]

Ok, thank you. I will try it tomorrow

[wf9a5m75]

As far as I understand, @Cordova decorator is for static class, isn't it?
I think @CordovaInstance because BaseClass is not static class.

I think there probably some mistakes in the index.ts, especially property names, constructor parameters.

[ihadeed]

@wf9a5m75

Cordova and CordovaInstance work the same way. The only difference is:

• Cordova applies method calls to the plugin's pluginRef
• CordovaIntance applies method calls to this._objectInstance

[wf9a5m75]

We haven't tested even 1/3 of all methods.

I appreciate if you join to the working channel on us, and join to the forked repo. Then you can modify, and we can also test it before merging to the ionic-team repo.

[wf9a5m75]

Oh, I see.

[ihadeed]

@wf9a5m75

Great!

I'll clone the repos and check them out soon.

[wf9a5m75]

Thank you for jumping on!
You don't need to work on the ionic-googlemaps-demo repo, but you can test it.

[wf9a5m75]

@ihadeed Well, we haven't checked all features yet, but at least lots of problems are fixed.
I really appreciate if you merge the code at once.
Thanks.

(Asking the problems of the current @ionic-native/googlemaps has been increasing...)

[wf9a5m75]

@ihadeed Could you update the npm at once?

I haven't checked all features, but the merge reduces troubles currently reported (user code is correct, but the current plugin is bad).