Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing options for BarcodeScanner #965

Closed
abennouna opened this issue Jan 11, 2017 · 1 comment
Closed

Missing options for BarcodeScanner #965

abennouna opened this issue Jan 11, 2017 · 1 comment

Comments

@abennouna
Copy link
Contributor

On Android, the resultDisplayDuration option from the Cordova plugin allows dismissing the scanned text display.

It may also be interesting to add torchOn option (Android only) that is provided by the Cordova plugin.

Should I submit a PR?
@ihadeed
Copy link
Collaborator

ihadeed commented Jan 11, 2017

Yes sure a PR would be nice. Thanks!

abennouna added a commit to abennouna/ionic-native that referenced this issue Jan 11, 2017
@abennouna
feat(barcodescanner): Add missing options
2b8b98a 
Fixes danielsogl#965
@abennouna abennouna mentioned this issue Jan 11, 2017
Merged
ihadeed pushed a commit that referenced this issue Jan 11, 2017
@abennouna @ihadeed
feat(barcodescanner): add missing options (#966)
e902856 
Fixes #965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abennouna @ihadeed