Skip to content

Commit

Permalink
fix(firebase-x): setConfigSettings function input parameters aligned …
Browse files Browse the repository at this point in the history
…with firebase-x plugin (#4757)

* Implement fix

* revert changes to firebase

* correct success callback

* fix jsdoc

* fix return type
  • Loading branch information
turanofff authored Apr 17, 2024
1 parent d607550 commit adb330a
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions src/@awesome-cordova-plugins/plugins/firebase-x/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export interface MessagePayloadAps {
alert?: {
title: string;
body: string;
}
};
}
export interface MessagePayload {
title?: string;
Expand Down Expand Up @@ -830,13 +830,20 @@ export class FirebaseX extends AwesomeCordovaNativePlugin {
}

/**
* Android only. Change the settings for the FirebaseRemoteConfig object's operations.
* Change the settings for the FirebaseRemoteConfig object's operations.
*
* @param {Object} settings
* @returns {Promise<any>}
* @param {number} fetchTimeout - fetch timeout in seconds. Default is 60 seconds.
* @param {number} minimumFetchInterval - minimum fetch inteval in seconds. Default is 12 hours.
* @param {Function} success - callback function to be call on successfully setting the remote config settings
* @param {Function} error - callback function which will be passed a {string} error message as an argument
*/
@Cordova()
setConfigSettings(settings: any): Promise<any> {
setConfigSettings(
fetchTimeout: number,
minimumFetchInterval: number,
success: () => void,
error: (err: string) => void
): void {
return;
}

Expand Down

0 comments on commit adb330a

Please sign in to comment.