Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass transfer #616

Merged
merged 20 commits into from
Feb 12, 2025
Merged

Mass transfer #616

merged 20 commits into from
Feb 12, 2025

Conversation

analulujg
Copy link
Contributor

Type of PR:
Bug fix

Description:
Fix issues with SETUP = masstransfer

  • Consistent units (in code units)
  • Parameters follow Jackson et al 2017
  • Use inject_windtunnel.f90 to successfully inject at L1 point
  • Fix a bug with dtinject in inject_windtunnel.f90
  • Fix external force parameters
  • Better options in the setup file

Testing:

    ~/phantom/scripts/writemake.sh masstransfer > Makefile
      make;  make setup
      ./phantomsetup wd.setup
      ./phantom wd.in

Did you run the bots? yes

Did you update relevant documentation in the docs directory? no

analulujg and others added 20 commits August 20, 2024 12:47
@analulujg
add case (6) integration of binary orbit in a corotate frame to test_…
a3c1860 
…binary
@analulujg
Merge branch 'masstransfer' of github.com:analulujg/phantom into mass…
0727404 
…transfer
@analulujg
Delete the corotating frame in mass transfer,
8e796cc 
add inject_rochelobe in the mass transfer setup in
Makefiles setup
Handle particles and change the velocity of injection
in inject inject_rochelobe
@analulujg
Change particle injection
bc0994f
@analulujg
Injection file for mass transfer setup
1c132d4
@analulujg
solve inconsistencies
4b779aa
@analulujg
delete inject_rochelobe.f90 and setup_masstransfer.f90
71b719d
@analulujg
add
618c3ab
@danieljprice
(windtunnel) fix windtunnel injection so it works for arbitrary wind …
b2d1e12 
…parameters WITHOUT a star being present; separate setup options from injection options; take particle mass directly as the input parameter for the mass resolution
@analulujg
Merge branch 'fix-windtunnel' of github.com:danieljprice/phantom into…
47de11e 
… masstransfer
@analulujg
fixed all the bugs in setup mass transfer
5b3a8c6
@analulujg
fix bug with dtinject
6c04726
@analulujg
Fix comments
bfad1c2
@analulujg
[header-bot] updated file headers
1e89e26
@analulujg
[space-bot] whitespace at end of lines removed
49d13bb
@analulujg
[author-bot] updated AUTHORS file
6a5d056
@analulujg
[indent-bot] standardised indentation
33dc8c8
@analulujg
[author-bot] updated AUTHORS file
79d64c9
@analulujg
fix mail map
05229a0
@analulujg
test fail fix
f228b3d
@danieljprice danieljprice mentioned this pull request Feb 12, 2025
Merged
@danieljprice danieljprice merged commit 85b2f73 into danieljprice:master Feb 12, 2025
119 of 180 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@analulujg @danieljprice