Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(set_binary, #302) minor fixes so printouts obey conventions #448

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

danieljprice
Copy link
Owner

Type of PR:
minor fixes to information printed out for hyperbolic/parabolic orbits (#302)

Description:
semi-major axis printed negative for hyperbolic orbits; period is printed as huge() for parabolic/hyperbolic orbits

Testing:

~/phantom/scripts/writemake.sh binary > Makefile
make setup
./phantomsetup orbit

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

…or hyperbolic; period is huge for parabolic/hyperbolic
@danieljprice danieljprice merged commit 9cb55c0 into master Jul 6, 2023
177 checks passed
@danieljprice danieljprice deleted the hyperbolic branch July 6, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant