Fixed problems with phantom2hdf5 not compilling and added missing got arrays for the reading of hdf5 files. #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing got arrays for hdf5 files.
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
Fixed problems with phantom2hdf5 not compilling and added missing got arrays for the reading of hdf5 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
Fixed various issues preventing the compilation of phantom2hdf5 and also added some missing got arrays (x, z, mu and nucleation) for the reading of hdf5 files.
Testing:
I successfully compiled phantom2hdf5 and made a readable .h5 file using it. I did not test the got arrays that I added.
Did you run the bots? yes