Added planetary destruction option and binding energy profile option to analysis_common_envelope.F90. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to analysis_common_envelope.F90.
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
…lopeModifications Added planetary destruction option and binding energy profile option to analysis_common_envelope.F90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
modification to existing code
Description:
I added two new options to analysis_common_envelope.F90; one that calculates information regarding Kelvin-Helmholtz based planetary destruction (from https://arxiv.org/abs/1210.0879) and another that creates binding energy profiles for the star (both including and excluding internal energy).
Testing:
I checked that the output of these new options have valid data.
Did you run the bots? yes