Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly reduced variables in nimhd test #235

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

conradtchan
Copy link
Collaborator

@conradtchan conradtchan commented Feb 16, 2022

Type of PR:
Bug fix

Description:
Required for #217

In a93bc90, as part of implementing MPI support for nimhd tests, the L2 error variables were reduced across tasks.

There is a typo resulting in the v_x and B_y error being overwritten by the density error. This produces a test failure due to the tolerance not being met.

In df72df1, NICIL 2.1 was added to phantom, where the tolerance for B_y was changed to tolb=3.1d-2. This was change was made possibly because the apparent improved accuracy was wrongly attributed to improvements to the code, rather than because the the density error was overwriting the B_y error.

tolb has been reverted to the original value of 1.1d-1.

This bug is not yet covered by the automated test suite because #217 has not been merged yet, and needs to be tested manually using the commands below.

Testing:

make MPI=yes SETUP=testnimhd OPENMP=no phantomtest
mpirun -n 4 bin/phantomtest nimhd

Did you run the bots? no, not required

@conradtchan conradtchan marked this pull request as ready for review February 17, 2022 00:04
@conradtchan conradtchan merged commit 20779bd into danieljprice:master Feb 17, 2022
@conradtchan conradtchan deleted the fix-nimhd-test branch February 17, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant