Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Message equality comparison #513

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Fix Message equality comparison #513

merged 1 commit into from
Jul 29, 2023

Conversation

atomicflag
Copy link
Contributor

Fixes #512

Gobot1234
Gobot1234 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Gobot1234 Gobot1234 merged commit 4cdf1bb into danielgtaylor:master Jul 29, 2023
17 checks passed
@atomicflag atomicflag deleted the features/fix-equality-comparison branch July 29, 2023 11:42
bbonenfant pushed a commit to pachyderm/python-betterproto that referenced this pull request Jan 23, 2024
@bbonenfant
Fix Message equality comparison (danielgtaylor#513)
36a6360
bbonenfant pushed a commit to pachyderm/python-betterproto that referenced this pull request Jan 23, 2024
@bbonenfant
Fix Message equality comparison (danielgtaylor#513)
722010b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gobot1234 Gobot1234 Gobot1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unconventional __eq__ method behavior
2 participants
@atomicflag @Gobot1234