Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.0.0b6 #500

Merged
merged 21 commits into from
Jun 25, 2023
Merged

Bump version to 2.0.0b6 #500

merged 21 commits into from
Jun 25, 2023

Conversation

ashwin153
Copy link
Contributor

No description provided.

@Gobot1234
Copy link
Collaborator

This still isn't ready for release. You'll also need to write a changelog for the beta release

@ashwin153 ashwin153 changed the title Bump version to 2.0.0 Bump version to 2.0.0b6 Jun 5, 2023
@ashwin153
Copy link
Contributor Author

@Gobot1234 Ready for you to look at again.

Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. Apart from the general nits I'd appreciate it if you made separated fixes from additions

@Gobot1234
Copy link
Collaborator

You also need to add 182aeda and 182aeda to this (sorry)

ashwin153 and others added 12 commits June 25, 2023 13:05
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
@ashwin153
Copy link
Contributor Author

@Gobot1234 Ready for you to look at again.

Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of things

Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of things

@Gobot1234
Copy link
Collaborator

Thank you for your work on this

@Gobot1234 Gobot1234 merged commit 098989e into danielgtaylor:master Jun 25, 2023
@MicaelJarniac
Copy link
Contributor

MicaelJarniac commented Jun 26, 2023

Will this be released on PyPI? The latest there seems to still be 2.0.0b5.
https://pypi.org/project/betterproto/#history

@Gobot1234
Copy link
Collaborator

The release action is currently failing cause @danielgtaylor's email isn't verified on pypi. We are working to remedy the situation

@danielgtaylor
Copy link
Owner

@Gobot1234 I can take a look, sorry about that.

@MicaelJarniac
Copy link
Contributor

I see it's now released there. Thanks a lot!
https://pypi.org/project/betterproto/2.0.0b6/

@ryaminal
Copy link

this is excellent. thanks to @ashwin153 and @Gobot1234 for the effort to get this out.

@ashwin153 ashwin153 deleted the patch-1 branch July 1, 2023 17:34
bbonenfant pushed a commit to pachyderm/python-betterproto that referenced this pull request Jan 23, 2024
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	pyproject.toml
bbonenfant added a commit to pachyderm/python-betterproto that referenced this pull request Jan 23, 2024
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	pyproject.toml

# Conflicts:
#	CHANGELOG.md
#	pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants