Fix dict encoding for timezone aware datetimes #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all this work |
Gobot1234
approved these changes
Apr 13, 2023
Gobot1234
changed the title
bbonenfant
pushed a commit
to pachyderm/python-betterproto
that referenced
this pull request
Jan 23, 2024
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
bbonenfant
pushed a commit
to pachyderm/python-betterproto
that referenced
this pull request
Jan 23, 2024
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #467
When a timezone-aware datetime object is encoded via
_Timestamp.timestamp_to_jsonits timezone information is stripped and it is encoded as if it is UTC. This caused the decoded datetime from the dict to refer to a different point in time from the original datetime. Since the JSON serialization routine calls the dict encode routine this problem also affects JSON.I added a check in
_Timestamp.timestamp_to_jsonthat converts timezone-aware datetime object to UTC before stripping the timezone and encoding. I also added some tests to check that timezone-aware datetime objects are encoded and decoded correctly. Naive datetime objects are still treated as UTC which is unchanged.