New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `_stream_unary` not working with empty iterables #422

Merged

cetanu merged 3 commits into danielgtaylor:master from spietras:empty-iterables

Oct 17, 2023

Contributor

spietras commented Sep 22, 2022

_stream_unary now sends request first, so even if iterable is empty, the request is sent
Added tests to check if stream_unary and stream_stream methods work with empty iterables
Fixed do_many_thing method in ThingService using for instead of async for on Stream

Closes #421

spietras added 3 commits

September 22, 2022 21:23


          Fixed do_many_things method in ThingService

19db759


          Added test for empty iterables

9e6bee6


          Fixed _stream_unary not sending request first

ded2cb2

spietras mentioned this pull request

_stream_unary doesn't work with empty iterables #421

Closed

cetanu approved these changes

View reviewed changes

cetanu merged commit e309513 into danielgtaylor:master

spietras deleted the empty-iterables branch

December 29, 2023 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet