Allow parsing messages from byteslike #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when passing a
memoryview
as an arguments toFromString
/parse
, an exception may sometimes be raised:Click me to see stacktrace
I believe this happens when trying to deserialize strings from the memoryview here. This fails because memoryview (like many other byteslike) do not have a decode function. Instead, to create a string from a byteslike, one must use the
str(object, encoding)
constructor.Having the ability to pass memoryviews (and other byteslike) to betterproto would be nice, as it would prevent needless copies of bytes each time a subslice is necessary.