fix: Map field edge-case #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gobot1234
previously approved these changes
Mar 29, 2022
During the check wheter a field is a "map", the string "entry" is added to the field name, checked against the type name and then further checks are made against the nested type of a parent message. In this edge-case, the first check would pass even though it shouldn't and that would cause an error because the parent type does not have a "nested_type" attribute.
|
Thank you for approving the PR. The tests are failing and I'm looking into it. Seems to be a problem with test data generation. |
Luminaar
force-pushed
the
fix/is-map-edge-case
branch
from
6801210
to
08eed0d
Compare
|
Found the issue. The package directive was missing in my test proto file. |
Gobot1234
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've hit upon this weird edge-case when using
betterprotoin our project.It took me a while to find the cause (especially realizing that the field name caused the problem)
but the solution is quite simple. I've tried to find a better way to check for the map field type
but was unable to find one (I'm not very familiar with the protobuf internals).