Fixes for Python 3.9 #140
Merged
Fixes for Python 3.9 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-n
reviewed
Aug 16, 2020
|
Looks like the new CI config doesn't work? |
|
Yeah I'm not too sure what's up with it |
Merged
|
Looks like it's been fixed, I take it back |
|
Not a clue what to do about this |
# Conflicts: # poetry.lock # pyproject.toml
|
Can we cherry pick the actual fix to merged and leave the tests as a separate PR to be merged once 3.9 plays better? |
|
Building wheels for dependencies seems like an impossible task in actions. |
nat-n
approved these changes
Oct 15, 2020
|
It was due to me experimenting with checking system platform specific dependencies. |
>>> import typing
>>> def func(t: typing.List[str]):
... pass
...
>>> typing.get_type_hints(func)["t"]
typing.List[str]
>>> type(typing.get_type_hints(func)["t"])
<class 'typing._GenericAlias'>
>>> type(typing.List)
<class 'typing._SpecialGenericAlias'>
>>> type(typing.List) is type(typing.get_type_hints(func)["t"])
FalseI think this is the actual bug. |
nat-n
requested changes
Oct 17, 2020
|
Should be ready to go now :) |
nat-n
approved these changes
Nov 1, 2020
Merged
Gobot1234
added a commit
to Gobot1234/python-betterproto
that referenced
this pull request
Dec 18, 2020
Fix issue in logic for evaluating field types affecting python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type(field_type)can now be<class 'list'>breaking the old method of checking.