Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile in Delphi Seattle #71

Closed
dsonda opened this issue Feb 22, 2017 · 1 comment
Closed

Does not compile in Delphi Seattle #71

dsonda opened this issue Feb 22, 2017 · 1 comment

Comments

@dsonda
Copy link
Contributor

dsonda commented Feb 22, 2017

I've updated the framework to the last version and now it's not compiling any more.
It seems to be after commit 03d9041.
I'm using Delphi 10 Seattle.

Errors:
[dcc32 Error] MVCFramework.pas(1650): E2010 Incompatible types: 'Byte' and 'AnsiChar'
[dcc32 Error] MVCFramework.pas(1656): E2250 There is no overloaded version of 'GetString' that can be called with these arguments

At unit MVCFramework.pas:

function TMVCWebRequest.Body: string;
var
Encoding: TEncoding;
Buffer: TArray;
I: Integer;
begin
if (FBody = '') then
begin
if (FCharset = '') then
begin
SetLength(Buffer, 10);
for I := 0 to 9 do
Buffer[I] := FWebRequest.RawContent[I];
TEncoding.GetBufferEncoding(Buffer, Encoding, TEncoding.Default);
SetLength(Buffer, 0);
end
else
Encoding := TEncoding.GetEncoding(FCharset);
FBody := Encoding.GetString(FWebRequest.RawContent);
end;
Result := FBody;
end;

dsonda added a commit to dsonda/delphimvcframework that referenced this issue Feb 22, 2017
danieleteti added a commit that referenced this issue Feb 22, 2017
Fix issue #71: Does not compile in Delphi Seattle
@danieleteti
Copy link
Owner

Closed in 2.1.4 (beryllium)

danieleteti added a commit that referenced this issue Feb 22, 2017
Version 2.1.4 (beryllium)
danieleteti added a commit that referenced this issue Oct 18, 2023
0d39e1d1 New LogLevel: FATAL
5248b9de Improved fileformatname check
657a539d danieleteti/loggerpro#79
67729f57 danieleteti/loggerpro#72
f05a91a6 danieleteti/loggerpro#73
3c805c0f Merge pull request #71 from luebbe/master
3a790459 Fixes #70 Add test to expose #70

git-subtree-dir: lib/loggerpro
git-subtree-split: 0d39e1d1549d42fa20b71503eed944043771b7bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants