Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helping #2

Merged
merged 3 commits into from
Sep 15, 2016
Merged

Helping #2

merged 3 commits into from
Sep 15, 2016

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Sep 15, 2016

No description provided.

@mikecann
Copy link

Hahaha I noticed that too ;)

@basarat basarat changed the title Unused import Helping Sep 15, 2016
@basarat
Copy link
Contributor Author

basarat commented Sep 15, 2016

@danielearwicker Just trying to help here. Can clean up PR / drop ideas based on review 🌹

@basarat
Copy link
Contributor Author

basarat commented Sep 15, 2016

Hahaha I noticed that too ;)

Actually those imports prevent this tsc error : https://travis-ci.org/danielearwicker/immuto/jobs/160050143#L195 I honestly haven't seen it before. Just looking away 👀 for now 🌹

@basarat
Copy link
Contributor Author

basarat commented Sep 15, 2016 •
edited
Loading

Put in an explicit tsc version because : https://travis-ci.org/danielearwicker/immuto/jobs/160053794#L191. Its just for our dev. Doesn't impact the version people use 🌹

basarat
basarat commented Sep 15, 2016
View reviewed changes
Copy link
Contributor Author

@basarat basarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking Change. Feel free to batch it up with the next one.

@danielearwicker danielearwicker merged commit 199a5d8 into danielearwicker:master Sep 15, 2016
@danielearwicker
Copy link
Owner

Thanks! 👍

Re: the error about types that cannot be named, I had a report from someone about that error in another library, same problem, but they only got it in WebStorm. But with 2.0 rc I see it in command-line tsc builds. It feels like a TS bug to me.

@danielearwicker
Copy link
Owner

@basarat re: error about has or is using name..., looks like this is caused by --declaration. For apps that don't need to generate .d.ts it wouldn't be an issue.

@basarat basarat deleted the patch-1 branch September 15, 2016 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basarat @mikecann @danielearwicker