-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement INCR, INCRBY, INCRBYFLOAT, DECR and DECRBY commands #216
Conversation
… for the INCR, DECR, INCRBY, DECRBY and INCRBYFLOAT commands
… considered invalid
…ng double numbers so it's necessary to increase the amount of stack available from 32kb to 40kb
Codecov ReportBase: 80.35% // Head: 80.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 80.35% 80.56% +0.20%
==========================================
Files 135 145 +10
Lines 8062 8435 +373
==========================================
+ Hits 6478 6795 +317
- Misses 1584 1640 +56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR implements a number of commands to increment and decrement integers and floats, namely the INCR, INCRBY, INCRBYFLOAT, DECR and DECRBY commands.
The PR includes also the require tests to ensure that they are working fine and their behaviour matches Redis behaviour.
In the PR there is also a change included to handle massive stack requests from the sprintf command, to handle very large long double numbers sprintf gets past the current stack of 32kb therefore it has been extended to 40kb.