Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keys command #203

Merged
merged 8 commits into from
Aug 29, 2022
Merged

Implement keys command #203

merged 8 commits into from
Aug 29, 2022

Conversation

danielealbano
Copy link
Owner

This PR implements the KEYS command, a new op for the storage db to fetch all the keys matching a glob pattern, a glob pattern matchinf function and all the required tests for the KEYS command.

@danielealbano danielealbano added the enhancement New feature or request label Aug 29, 2022
@danielealbano danielealbano added this to the v0.2 milestone Aug 29, 2022
@danielealbano danielealbano self-assigned this Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 80.87% // Head: 80.50% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (4cc3329) compared to base (5a5283d).
Patch coverage: 63.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   80.87%   80.50%   -0.37%     
==========================================
  Files         131      132       +1     
  Lines        7801     7991     +190     
==========================================
+ Hits         6309     6433     +124     
- Misses       1492     1558      +66     
Impacted Files Coverage Δ
src/utils_string_sw.c 100.00% <ø> (ø)
src/utils_string.c 55.80% <53.91%> (-24.20%) ⬇️
src/module/redis/module_redis_connection.c 73.10% <76.47%> (+0.17%) ⬆️
src/storage/db/storage_db.c 64.94% <86.67%> (+1.23%) ⬆️
...c/module/redis/command/module_redis_command_keys.c 87.50% <87.50%> (ø)
src/module/redis/module_redis_command.c 82.97% <0.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant