Remove pbkdf2 optional dependency, update instructions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielberkompas
force-pushed
the
pbkdf2-otp-24
branch
from
948833f to
5fa945c
Compare
It isn't possible to publish a package to Hex.pm with a dependency on a Github fork which is not also hosted on Hex.pm. The current version of `pbkdf2` is not compatible with Erlang 24. To use it, you'll need a forked version, see #24. For this reason, I needed to make the `pbkdf2` a `:dev, :test` dependency instead of an `:optional` dependency for `cloak_ecto`. If you add it to your mix dependencies in your project, `cloak_ecto` should still detect it; it shouldn't need to be listed as an optional dependency.
danielberkompas
force-pushed
the
pbkdf2-otp-24
branch
from
5fa945c to
d9d2fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't possible to publish a package to Hex.pm with a dependency on a Github fork which is not also hosted on Hex.pm. The current version of
pbkdf2is not compatible with Erlang 24. To use it, you'll need a forked version, see #24.For this reason, I needed to make the
pbkdf2a:dev, :testdependency instead of an:optionaldependency forcloak_ecto. If you add it to your mix dependencies in your project,cloak_ectoshould still detect it; it shouldn't need to be listed as an optional dependency.I updated the instructions in the module doc for
Cloak.Ecto.PBKDF2to reflect this information.