test: validating JSON files #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
12
to
16
| describe "frameworks JSON validation" do | ||
| test "validates priv/repo/data/frameworks.json file", %{frameworks: frameworks} do | ||
| assert Enum.all?(frameworks, &valid/1) | ||
| end | ||
| end |
There was a problem hiding this comment.
Looks very clean! I like this approach 🔥
Adds a basic schema validation module based around Ecto changesets. Implements the pattern across current JSON files
johnmcguin
force-pushed
the
validate_json
branch
from
3b97ff9
to
625d2b9
Compare
johnmcguin
changed the title
danielbergholz
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
This is impressive work @johnmcguin, thanks a lot! Now I'm much more confident when adding any new data on the JSON files 🚀
|
woohoo, thanks @danielbergholz ! Happy to find such a cool project to contribute to! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change being made?
resolves #78
How is this being accomplished?
use, providing Ecto schemaless types for each JSON filevalid?: trueEcto changeset.Some caveats I wanted to note:
casting will not catch a typo like "names" instead of "name". It simply won't include those properties in the changes.requiredargument whenuseing the module. This is the main validation I included and consulted the schemas as to what fields should be required.validate/1function in a test file. For example, if you needed or wanted to perform additional validations on the changeset for that particular test file.