Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent type='file' from being overwritten #628

Merged
merged 1 commit into from
Mar 17, 2015
Merged

Prevent type='file' from being overwritten #628

merged 1 commit into from
Mar 17, 2015

Conversation

ChrisMBarr
Copy link
Contributor

if you have:

<button type='button" ng-file-select>upload some files</button>

this will prevent the created <input type='file' /> element from having it's type attribute overwritten.

if you have `<button type='button" ng-file-select>upload some files</button>` this will prevent the created `<input type='file` />` element from having it's `type` attribute overwritten.
danialfarid added a commit that referenced this pull request Mar 17, 2015
Prevent type='file' from being overwritten
@danialfarid danialfarid merged commit 37fe784 into danialfarid:master Mar 17, 2015
danialfarid pushed a commit that referenced this pull request Mar 17, 2015
@danialfarid
Copy link
Owner

Thanks,

Fixed in version 3.2.5

@ChrisMBarr
Copy link
Contributor Author

Wow, that was quick. thanks! Now I'll just use the official version in my project instead of my patched one.

@recurrence
Copy link

3.2.5 was not tagged in github's versions

@Frank3K
Copy link
Contributor

Frank3K commented Apr 8, 2015

+1

Waiting for the 3.2.5 tag / release to resolve this issue.

@alanchrt
Copy link

alanchrt commented Apr 9, 2015

+1 also looking forward to the 3.2.5 release on this one.

danialfarid pushed a commit that referenced this pull request Apr 13, 2015
…and some IE8-9 bugs and styling issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants