Update Rust and crates #5248
Update Rust and crates #5248
Conversation
BlackDex
commented
Nov 29, 2024
•
BlackDex
commented
- Updated Rust to v1.83.0
- Updated MSRV to v1.82.0 (Needed for html5gum crate)
- Updated icon fetching code to match new html5gum version
- Updated workflows
- Enabled edition 2024 clippy lints Nightly reports some clippy hints, but that would be too much to change in this PR i think.
- Added crate patches for the fern and yubico crates to update more dependencies
- Fixed an issue with the diesel_logger in combination with the SQLite backup feature
- Updated Rust to v1.83.0 - Updated MSRV to v1.82.0 (Needed for html5gum crate) - Updated icon fetching code to match new html5gum version - Updated workflows - Enabled edition 2024 clippy lints Nightly reports some clippy hints, but that would be too much to change in this PR i think. Signed-off-by: BlackDex <black.dex@gmail.com>
|
Looks like the Rust v1.83.0 images are not yet available |
|
Perhaps we could also use commit daboross/fern@3e775cc as an override for fern in order to have |
- Patch fern to allow syslog-7 feature - Fixed diesel logger which was broken because of the sqlite backup feature Refactored the sqlite backup because of this - Added a build workflow test to include the query_logger feature Signed-off-by: BlackDex <black.dex@gmail.com>
|
@dfunkt, yea that might be a good one. Looks like the image is still not available :(. |
|
We could keep the docker files on v1.82.0, the correct version will be pulled anyway. |
|
@dani-garcia, we could also patch yubikey-rs which causes several duplicate dependencies to be removed. It would then be based from my forked repo where the PR is coming from. yubico = { git = "https://github.com/BlackDex/yubico-rs", rev = "00df14811f58155c0f02e3ab10f1570ed3e115c6" } |
BlackDex
force-pushed
the
update-rust-and-crates
branch
2 times, most recently
from
30c8283 to
08c880c
Compare
Signed-off-by: BlackDex <black.dex@gmail.com>
BlackDex
force-pushed
the
update-rust-and-crates
branch
from
08c880c to
eb17609
Compare
| err_silent!("The 'sqlite' feature is not enabled. Backups only works for SQLite databases") | ||
| async fn backup_sqlite() -> Result<String, Error> { | ||
| use crate::db::{backup_database, DbConnType}; | ||
| if DbConnType::from_url(&CONFIG.database_url()).map(|t| t == DbConnType::sqlite).unwrap_or(false) { |
There was a problem hiding this comment.
Do we need to check for the database type here? We're already doing that inside backup_database as far as I can see.
