Fix iOS sync by converting field types to int #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the iOS clients are not able to handle the `type` key within the `fields` array when they are of the type string. All other clients seem to handle this just fine though. This PR fixes this by validating it is a number, if this is not the case, try to convert the string to a number, or return the default of `1`. `1` is used as this is the type `hidden` and should prevent accidental data disclosure. Fixes dani-garcia#5069 Possibly Fixes dani-garcia#5016 Possibly Fixes dani-garcia#5002 Signed-off-by: BlackDex <black.dex@gmail.com>
dani-garcia
approved these changes
Oct 13, 2024
|
Curious if Bitwarden fixes their iOS client to properly handle this, would this fix then be pulled from the VW code since it would (or might) no longer be needed? Im sure this occurs everywhere, but how/when/where would one know to go back to an area in the code to remove things that are no longer needed? Like code clean up |
|
I think not. Types are fixed in json, and Bitwarden was very flexible with this, same like the camelCase and PasalCase. The new clients are more strict, and need to have less checks of course, but this does mean it could case issues if the server doesn't format the data correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the iOS clients are not able to handle the
typekey within thefieldsarray when they are of the type string.All other clients seem to handle this just fine though.
This PR fixes this by validating it is a number, if this is not the case, try to convert the string to a number, or return the default of
1.1is used as this is the typehiddenand should prevent accidental data disclosure.Fixes #5069
Possibly Fixes #5016
Possibly Fixes #5002