fix emergency access invites #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackDex
previously approved these changes
Feb 16, 2024
|
@BlackDex while testing it more thoroughly I found an easy way to break the emergency access contact list (when mail is enabled). To replicate:
I've added a fix for the bug (which does not affect systems when mail is disabled because there will be an entry in the Invitation table) and improved the handling of emergency access contacts if their corresponding user entry is missing. |
stefan0xC
changed the title
|
Ah! Good catch! |
stefan0xC
force-pushed
the
fix-emergency-access
branch
from
e3ee99b to
e5c7c21
Compare
stefan0xC
force-pushed
the
fix-emergency-access
branch
from
e5c7c21 to
79b26b3
Compare
when mail is disabled instead of accepting emergency access for all invited users automatically, we only accept if the user already exists on registration of a new account any open emergency access invitations will be accepted, if mail is disabled also prevent invited emergency access contacts to register if emergency access is disabled (this is only relevant for when mail is enabled, if mail is disabled they should have an Invitation entry)
if an invited user is deleted in the /admin panel their emergency access invitation will remain in the database which causes the to_json_grantee_details fn to panic
instead of returning an empty emergency access contact the entry should not be added to the list. also the error handling can be improved a bit.
stefan0xC
force-pushed
the
fix-emergency-access
branch
from
79b26b3 to
e617630
Compare
|
@dani-garcia this PR looks ready as well. |
dani-garcia
approved these changes
Apr 27, 2024
ZhReimu
pushed a commit
to ZhReimu/vaultwarden
that referenced
this pull request
Jul 9, 2024
* fix emergency access invites with no mail when mail is disabled instead of accepting emergency access for all invited users automatically, we only accept if the user already exists on registration of a new account any open emergency access invitations will be accepted, if mail is disabled also prevent invited emergency access contacts to register if emergency access is disabled (this is only relevant for when mail is enabled, if mail is disabled they should have an Invitation entry) * delete emergency access invitations if an invited user is deleted in the /admin panel their emergency access invitation will remain in the database which causes the to_json_grantee_details fn to panic * improve missing emergency access grantees instead of returning an empty emergency access contact the entry should not be added to the list. also the error handling can be improved a bit.
renovate bot
referenced
this pull request
in NorkzYT/Wolflith
Jul 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | minor | `1.30.5` -> `1.31.0` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.31.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.31.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.5...1.31.0) #### Major changes and New Features - Initial support for the beta releases of the new native mobile apps - Removed support for WebSocket traffic on port 3012, as it's been integrated on the main HTTP port for a few releases - Updated included web vault to 2024.5.1 #### General mention Bitwarden has changed the push API endpoints which affects the EU region endpoint users. So if you use the push functionality and use the EU region you need to make some changes. You have to update `push.bitwarden.eu` to `api.bitwarden.eu`. This is also an issue with any previous version of Vaultwarden. #### What's Changed - chore: remove repetitive words by [@​one230six](https://togithub.com/one230six) in [https://github.com/dani-garcia/vaultwarden/pull/4422](https://togithub.com/dani-garcia/vaultwarden/pull/4422) - Fix comment in events.rs by [@​KrappRamiro](https://togithub.com/KrappRamiro) in [https://github.com/dani-garcia/vaultwarden/pull/4408](https://togithub.com/dani-garcia/vaultwarden/pull/4408) - Improve JWT RSA key initialization and avoid saving public key by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4085](https://togithub.com/dani-garcia/vaultwarden/pull/4085) - Remove custom WebSocket code by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4001](https://togithub.com/dani-garcia/vaultwarden/pull/4001) - refactor: replace panic with a graceful exit by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/4402](https://togithub.com/dani-garcia/vaultwarden/pull/4402) - Small improvements around email change by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4415](https://togithub.com/dani-garcia/vaultwarden/pull/4415) - Change timestamp data type. by [@​gzfrozen](https://togithub.com/gzfrozen) in [https://github.com/dani-garcia/vaultwarden/pull/4355](https://togithub.com/dani-garcia/vaultwarden/pull/4355) - Fix [#​3624](https://togithub.com/dani-garcia/vaultwarden/issues/3624): fix manager permission within groups by [@​matlink](https://togithub.com/matlink) in [https://github.com/dani-garcia/vaultwarden/pull/3754](https://togithub.com/dani-garcia/vaultwarden/pull/3754) - automatically use email address as 2fa provider by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4317](https://togithub.com/dani-garcia/vaultwarden/pull/4317) - fix: typos by [@​testwill](https://togithub.com/testwill) in [https://github.com/dani-garcia/vaultwarden/pull/4440](https://togithub.com/dani-garcia/vaultwarden/pull/4440) - Update chrono and sqlite by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4436](https://togithub.com/dani-garcia/vaultwarden/pull/4436) - Update Rust and crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4445](https://togithub.com/dani-garcia/vaultwarden/pull/4445) - Use async verify for Yubikey by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4448](https://togithub.com/dani-garcia/vaultwarden/pull/4448) - update web-vault to v2024.3.1 (new vertical layout) by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4468](https://togithub.com/dani-garcia/vaultwarden/pull/4468) - Update crates and some Clippy fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4475](https://togithub.com/dani-garcia/vaultwarden/pull/4475) - Update Key Rotation web-vault v2024.3.x by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4446](https://togithub.com/dani-garcia/vaultwarden/pull/4446) - Update Crate and Rust by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4522](https://togithub.com/dani-garcia/vaultwarden/pull/4522) - Implement custom DNS resolver by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/3988](https://togithub.com/dani-garcia/vaultwarden/pull/3988) - Add extra (unsupported) container build arch's by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4524](https://togithub.com/dani-garcia/vaultwarden/pull/4524) - Pass in collection ids to notifier when sharing cipher. by [@​kristof-mattei](https://togithub.com/kristof-mattei) in [https://github.com/dani-garcia/vaultwarden/pull/4517](https://togithub.com/dani-garcia/vaultwarden/pull/4517) - improve access to collections via groups by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4441](https://togithub.com/dani-garcia/vaultwarden/pull/4441) - fix emergency access invites by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4337](https://togithub.com/dani-garcia/vaultwarden/pull/4337) - Some fixes for the new mobile apps by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4526](https://togithub.com/dani-garcia/vaultwarden/pull/4526) - Update Rust, crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4558](https://togithub.com/dani-garcia/vaultwarden/pull/4558) - Improve Commentary Aesthetics by [@​rich-purnell](https://togithub.com/rich-purnell) in [https://github.com/dani-garcia/vaultwarden/pull/4549](https://togithub.com/dani-garcia/vaultwarden/pull/4549) - Optimize Dockerfiles by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4532](https://togithub.com/dani-garcia/vaultwarden/pull/4532) - also delete organization_api_key when deleting organizations by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4557](https://togithub.com/dani-garcia/vaultwarden/pull/4557) - Fix public api for domains with path prefix by [@​FDHoho007](https://togithub.com/FDHoho007) in [https://github.com/dani-garcia/vaultwarden/pull/4500](https://togithub.com/dani-garcia/vaultwarden/pull/4500) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4587](https://togithub.com/dani-garcia/vaultwarden/pull/4587) - Fix web-vault version in Docker(files/Settings) by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4575](https://togithub.com/dani-garcia/vaultwarden/pull/4575) - Update Alpine to version 3.20 by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4583](https://togithub.com/dani-garcia/vaultwarden/pull/4583) - differentiate external groups by organization id by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4586](https://togithub.com/dani-garcia/vaultwarden/pull/4586) - Remove old knowndevice route by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4578](https://togithub.com/dani-garcia/vaultwarden/pull/4578) - Update admin interface dependencies by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4581](https://togithub.com/dani-garcia/vaultwarden/pull/4581) - Update rust and remove unused header values by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4645](https://togithub.com/dani-garcia/vaultwarden/pull/4645) - Update crates, web-vault and GHA by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4648](https://togithub.com/dani-garcia/vaultwarden/pull/4648) - Fix some nightly build errors by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4657](https://togithub.com/dani-garcia/vaultwarden/pull/4657) - Fix some more nightly errors and remove lint that will become an error by default by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4661](https://togithub.com/dani-garcia/vaultwarden/pull/4661) - Change API and structs to camelCase by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4386](https://togithub.com/dani-garcia/vaultwarden/pull/4386) - Fix cipher creation on new android app by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4670](https://togithub.com/dani-garcia/vaultwarden/pull/4670) - Remove mimalloc workaround by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4606](https://togithub.com/dani-garcia/vaultwarden/pull/4606) - Change some missing PascalCase keys by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4671](https://togithub.com/dani-garcia/vaultwarden/pull/4671) - Fix collections and native app issue by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4685](https://togithub.com/dani-garcia/vaultwarden/pull/4685) - Fix duplicate folder creations during import by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4702](https://togithub.com/dani-garcia/vaultwarden/pull/4702) - Remove duplicate registry step by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4703](https://togithub.com/dani-garcia/vaultwarden/pull/4703) - add group support for Cipher::get_collections() by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4592](https://togithub.com/dani-garcia/vaultwarden/pull/4592) - Switch registry cache compression algorithm to zstd by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4704](https://togithub.com/dani-garcia/vaultwarden/pull/4704) - Update crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4714](https://togithub.com/dani-garcia/vaultwarden/pull/4714) - Some fixes for emergency access by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4715](https://togithub.com/dani-garcia/vaultwarden/pull/4715) #### New Contributors - [@​one230six](https://togithub.com/one230six) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4422](https://togithub.com/dani-garcia/vaultwarden/pull/4422) - [@​KrappRamiro](https://togithub.com/KrappRamiro) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4408](https://togithub.com/dani-garcia/vaultwarden/pull/4408) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4440](https://togithub.com/dani-garcia/vaultwarden/pull/4440) - [@​kristof-mattei](https://togithub.com/kristof-mattei) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4517](https://togithub.com/dani-garcia/vaultwarden/pull/4517) - [@​rich-purnell](https://togithub.com/rich-purnell) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4549](https://togithub.com/dani-garcia/vaultwarden/pull/4549) - [@​dfunkt](https://togithub.com/dfunkt) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4532](https://togithub.com/dani-garcia/vaultwarden/pull/4532) - [@​FDHoho007](https://togithub.com/FDHoho007) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4500](https://togithub.com/dani-garcia/vaultwarden/pull/4500) **Full Changelog**: dani-garcia/vaultwarden@1.30.5...1.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/NorkzYT/Wolflith). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoic3RhZ2luZyIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJtaW5vciIsInJlbm92YXRlIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
truecharts-admin
referenced
this pull request
in truecharts/public
Jul 24, 2024
](https://renovatebot.com){kind=link}
…1.31.0@4e28425 by renovate (#24153) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | minor | `1.30.5` -> `1.31.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (docker.io/vaultwarden/server)</summary> ### [`v1.31.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.31.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.5...1.31.0) #### Major changes and New Features - Initial support for the beta releases of the new native mobile apps - Removed support for WebSocket traffic on port 3012, as it's been integrated on the main HTTP port for a few releases - Updated included web vault to 2024.5.1 #### General mention Bitwarden has changed the push API endpoints which affects the EU region endpoint users. So if you use the push functionality and use the EU region you need to make some changes. You have to update `push.bitwarden.eu` to `api.bitwarden.eu`. This is also an issue with any previous version of Vaultwarden. #### What's Changed - chore: remove repetitive words by [@​one230six](https://togithub.com/one230six) in [https://github.com/dani-garcia/vaultwarden/pull/4422](https://togithub.com/dani-garcia/vaultwarden/pull/4422) - Fix comment in events.rs by [@​KrappRamiro](https://togithub.com/KrappRamiro) in [https://github.com/dani-garcia/vaultwarden/pull/4408](https://togithub.com/dani-garcia/vaultwarden/pull/4408) - Improve JWT RSA key initialization and avoid saving public key by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4085](https://togithub.com/dani-garcia/vaultwarden/pull/4085) - Remove custom WebSocket code by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4001](https://togithub.com/dani-garcia/vaultwarden/pull/4001) - refactor: replace panic with a graceful exit by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/4402](https://togithub.com/dani-garcia/vaultwarden/pull/4402) - Small improvements around email change by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4415](https://togithub.com/dani-garcia/vaultwarden/pull/4415) - Change timestamp data type. by [@​gzfrozen](https://togithub.com/gzfrozen) in [https://github.com/dani-garcia/vaultwarden/pull/4355](https://togithub.com/dani-garcia/vaultwarden/pull/4355) - Fix [#​3624](https://togithub.com/dani-garcia/vaultwarden/issues/3624): fix manager permission within groups by [@​matlink](https://togithub.com/matlink) in [https://github.com/dani-garcia/vaultwarden/pull/3754](https://togithub.com/dani-garcia/vaultwarden/pull/3754) - automatically use email address as 2fa provider by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4317](https://togithub.com/dani-garcia/vaultwarden/pull/4317) - fix: typos by [@​testwill](https://togithub.com/testwill) in [https://github.com/dani-garcia/vaultwarden/pull/4440](https://togithub.com/dani-garcia/vaultwarden/pull/4440) - Update chrono and sqlite by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4436](https://togithub.com/dani-garcia/vaultwarden/pull/4436) - Update Rust and crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4445](https://togithub.com/dani-garcia/vaultwarden/pull/4445) - Use async verify for Yubikey by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4448](https://togithub.com/dani-garcia/vaultwarden/pull/4448) - update web-vault to v2024.3.1 (new vertical layout) by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4468](https://togithub.com/dani-garcia/vaultwarden/pull/4468) - Update crates and some Clippy fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4475](https://togithub.com/dani-garcia/vaultwarden/pull/4475) - Update Key Rotation web-vault v2024.3.x by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4446](https://togithub.com/dani-garcia/vaultwarden/pull/4446) - Update Crate and Rust by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4522](https://togithub.com/dani-garcia/vaultwarden/pull/4522) - Implement custom DNS resolver by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/3988](https://togithub.com/dani-garcia/vaultwarden/pull/3988) - Add extra (unsupported) container build arch's by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4524](https://togithub.com/dani-garcia/vaultwarden/pull/4524) - Pass in collection ids to notifier when sharing cipher. by [@​kristof-mattei](https://togithub.com/kristof-mattei) in [https://github.com/dani-garcia/vaultwarden/pull/4517](https://togithub.com/dani-garcia/vaultwarden/pull/4517) - improve access to collections via groups by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4441](https://togithub.com/dani-garcia/vaultwarden/pull/4441) - fix emergency access invites by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4337](https://togithub.com/dani-garcia/vaultwarden/pull/4337) - Some fixes for the new mobile apps by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4526](https://togithub.com/dani-garcia/vaultwarden/pull/4526) - Update Rust, crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4558](https://togithub.com/dani-garcia/vaultwarden/pull/4558) - Improve Commentary Aesthetics by [@​rich-purnell](https://togithub.com/rich-purnell) in [https://github.com/dani-garcia/vaultwarden/pull/4549](https://togithub.com/dani-garcia/vaultwarden/pull/4549) - Optimize Dockerfiles by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4532](https://togithub.com/dani-garcia/vaultwarden/pull/4532) - also delete organization_api_key when deleting organizations by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4557](https://togithub.com/dani-garcia/vaultwarden/pull/4557) - Fix public api for domains with path prefix by [@​FDHoho007](https://togithub.com/FDHoho007) in [https://github.com/dani-garcia/vaultwarden/pull/4500](https://togithub.com/dani-garcia/vaultwarden/pull/4500) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4587](https://togithub.com/dani-garcia/vaultwarden/pull/4587) - Fix web-vault version in Docker(files/Settings) by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4575](https://togithub.com/dani-garcia/vaultwarden/pull/4575) - Update Alpine to version 3.20 by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4583](https://togithub.com/dani-garcia/vaultwarden/pull/4583) - differentiate external groups by organization id by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4586](https://togithub.com/dani-garcia/vaultwarden/pull/4586) - Remove old knowndevice route by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4578](https://togithub.com/dani-garcia/vaultwarden/pull/4578) - Update admin interface dependencies by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4581](https://togithub.com/dani-garcia/vaultwarden/pull/4581) - Update rust and remove unused header values by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4645](https://togithub.com/dani-garcia/vaultwarden/pull/4645) - Update crates, web-vault and GHA by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4648](https://togithub.com/dani-garcia/vaultwarden/pull/4648) - Fix some nightly build errors by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4657](https://togithub.com/dani-garcia/vaultwarden/pull/4657) - Fix some more nightly errors and remove lint that will become an error by default by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4661](https://togithub.com/dani-garcia/vaultwarden/pull/4661) - Change API and structs to camelCase by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4386](https://togithub.com/dani-garcia/vaultwarden/pull/4386) - Fix cipher creation on new android app by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4670](https://togithub.com/dani-garcia/vaultwarden/pull/4670) - Remove mimalloc workaround by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4606](https://togithub.com/dani-garcia/vaultwarden/pull/4606) - Change some missing PascalCase keys by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4671](https://togithub.com/dani-garcia/vaultwarden/pull/4671) - Fix collections and native app issue by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4685](https://togithub.com/dani-garcia/vaultwarden/pull/4685) - Fix duplicate folder creations during import by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4702](https://togithub.com/dani-garcia/vaultwarden/pull/4702) - Remove duplicate registry step by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4703](https://togithub.com/dani-garcia/vaultwarden/pull/4703) - add group support for Cipher::get_collections() by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4592](https://togithub.com/dani-garcia/vaultwarden/pull/4592) - Switch registry cache compression algorithm to zstd by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4704](https://togithub.com/dani-garcia/vaultwarden/pull/4704) - Update crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4714](https://togithub.com/dani-garcia/vaultwarden/pull/4714) - Some fixes for emergency access by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4715](https://togithub.com/dani-garcia/vaultwarden/pull/4715) #### New Contributors - [@​one230six](https://togithub.com/one230six) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4422](https://togithub.com/dani-garcia/vaultwarden/pull/4422) - [@​KrappRamiro](https://togithub.com/KrappRamiro) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4408](https://togithub.com/dani-garcia/vaultwarden/pull/4408) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4440](https://togithub.com/dani-garcia/vaultwarden/pull/4440) - [@​kristof-mattei](https://togithub.com/kristof-mattei) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4517](https://togithub.com/dani-garcia/vaultwarden/pull/4517) - [@​rich-purnell](https://togithub.com/rich-purnell) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4549](https://togithub.com/dani-garcia/vaultwarden/pull/4549) - [@​dfunkt](https://togithub.com/dfunkt) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4532](https://togithub.com/dani-garcia/vaultwarden/pull/4532) - [@​FDHoho007](https://togithub.com/FDHoho007) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4500](https://togithub.com/dani-garcia/vaultwarden/pull/4500) **Full Changelog**: dani-garcia/vaultwarden@1.30.5...1.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC42IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
sp3nx0r
referenced
this pull request
in sp3nx0r/homelab
Aug 3, 2024
…#272) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | minor | `1.30.5` -> `1.31.0` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (docker.io/vaultwarden/server)</summary> ### [`v1.31.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.31.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.5...1.31.0) #### Major changes and New Features - Initial support for the beta releases of the new native mobile apps - Removed support for WebSocket traffic on port 3012, as it's been integrated on the main HTTP port for a few releases - Updated included web vault to 2024.5.1 #### General mention Bitwarden has changed the push API endpoints which affects the EU region endpoint users. So if you use the push functionality and use the EU region you need to make some changes. You have to update `push.bitwarden.eu` to `api.bitwarden.eu`. This is also an issue with any previous version of Vaultwarden. #### What's Changed - chore: remove repetitive words by [@​one230six](https://togithub.com/one230six) in [https://github.com/dani-garcia/vaultwarden/pull/4422](https://togithub.com/dani-garcia/vaultwarden/pull/4422) - Fix comment in events.rs by [@​KrappRamiro](https://togithub.com/KrappRamiro) in [https://github.com/dani-garcia/vaultwarden/pull/4408](https://togithub.com/dani-garcia/vaultwarden/pull/4408) - Improve JWT RSA key initialization and avoid saving public key by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4085](https://togithub.com/dani-garcia/vaultwarden/pull/4085) - Remove custom WebSocket code by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4001](https://togithub.com/dani-garcia/vaultwarden/pull/4001) - refactor: replace panic with a graceful exit by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/4402](https://togithub.com/dani-garcia/vaultwarden/pull/4402) - Small improvements around email change by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4415](https://togithub.com/dani-garcia/vaultwarden/pull/4415) - Change timestamp data type. by [@​gzfrozen](https://togithub.com/gzfrozen) in [https://github.com/dani-garcia/vaultwarden/pull/4355](https://togithub.com/dani-garcia/vaultwarden/pull/4355) - Fix [#​3624](https://togithub.com/dani-garcia/vaultwarden/issues/3624): fix manager permission within groups by [@​matlink](https://togithub.com/matlink) in [https://github.com/dani-garcia/vaultwarden/pull/3754](https://togithub.com/dani-garcia/vaultwarden/pull/3754) - automatically use email address as 2fa provider by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4317](https://togithub.com/dani-garcia/vaultwarden/pull/4317) - fix: typos by [@​testwill](https://togithub.com/testwill) in [https://github.com/dani-garcia/vaultwarden/pull/4440](https://togithub.com/dani-garcia/vaultwarden/pull/4440) - Update chrono and sqlite by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4436](https://togithub.com/dani-garcia/vaultwarden/pull/4436) - Update Rust and crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4445](https://togithub.com/dani-garcia/vaultwarden/pull/4445) - Use async verify for Yubikey by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4448](https://togithub.com/dani-garcia/vaultwarden/pull/4448) - update web-vault to v2024.3.1 (new vertical layout) by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4468](https://togithub.com/dani-garcia/vaultwarden/pull/4468) - Update crates and some Clippy fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4475](https://togithub.com/dani-garcia/vaultwarden/pull/4475) - Update Key Rotation web-vault v2024.3.x by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4446](https://togithub.com/dani-garcia/vaultwarden/pull/4446) - Update Crate and Rust by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4522](https://togithub.com/dani-garcia/vaultwarden/pull/4522) - Implement custom DNS resolver by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/3988](https://togithub.com/dani-garcia/vaultwarden/pull/3988) - Add extra (unsupported) container build arch's by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4524](https://togithub.com/dani-garcia/vaultwarden/pull/4524) - Pass in collection ids to notifier when sharing cipher. by [@​kristof-mattei](https://togithub.com/kristof-mattei) in [https://github.com/dani-garcia/vaultwarden/pull/4517](https://togithub.com/dani-garcia/vaultwarden/pull/4517) - improve access to collections via groups by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4441](https://togithub.com/dani-garcia/vaultwarden/pull/4441) - fix emergency access invites by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4337](https://togithub.com/dani-garcia/vaultwarden/pull/4337) - Some fixes for the new mobile apps by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4526](https://togithub.com/dani-garcia/vaultwarden/pull/4526) - Update Rust, crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4558](https://togithub.com/dani-garcia/vaultwarden/pull/4558) - Improve Commentary Aesthetics by [@​rich-purnell](https://togithub.com/rich-purnell) in [https://github.com/dani-garcia/vaultwarden/pull/4549](https://togithub.com/dani-garcia/vaultwarden/pull/4549) - Optimize Dockerfiles by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4532](https://togithub.com/dani-garcia/vaultwarden/pull/4532) - also delete organization_api_key when deleting organizations by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4557](https://togithub.com/dani-garcia/vaultwarden/pull/4557) - Fix public api for domains with path prefix by [@​FDHoho007](https://togithub.com/FDHoho007) in [https://github.com/dani-garcia/vaultwarden/pull/4500](https://togithub.com/dani-garcia/vaultwarden/pull/4500) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4587](https://togithub.com/dani-garcia/vaultwarden/pull/4587) - Fix web-vault version in Docker(files/Settings) by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4575](https://togithub.com/dani-garcia/vaultwarden/pull/4575) - Update Alpine to version 3.20 by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4583](https://togithub.com/dani-garcia/vaultwarden/pull/4583) - differentiate external groups by organization id by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4586](https://togithub.com/dani-garcia/vaultwarden/pull/4586) - Remove old knowndevice route by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/dani-garcia/vaultwarden/pull/4578](https://togithub.com/dani-garcia/vaultwarden/pull/4578) - Update admin interface dependencies by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4581](https://togithub.com/dani-garcia/vaultwarden/pull/4581) - Update rust and remove unused header values by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4645](https://togithub.com/dani-garcia/vaultwarden/pull/4645) - Update crates, web-vault and GHA by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4648](https://togithub.com/dani-garcia/vaultwarden/pull/4648) - Fix some nightly build errors by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4657](https://togithub.com/dani-garcia/vaultwarden/pull/4657) - Fix some more nightly errors and remove lint that will become an error by default by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4661](https://togithub.com/dani-garcia/vaultwarden/pull/4661) - Change API and structs to camelCase by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4386](https://togithub.com/dani-garcia/vaultwarden/pull/4386) - Fix cipher creation on new android app by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4670](https://togithub.com/dani-garcia/vaultwarden/pull/4670) - Remove mimalloc workaround by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4606](https://togithub.com/dani-garcia/vaultwarden/pull/4606) - Change some missing PascalCase keys by [@​dani-garcia](https://togithub.com/dani-garcia) in [https://github.com/dani-garcia/vaultwarden/pull/4671](https://togithub.com/dani-garcia/vaultwarden/pull/4671) - Fix collections and native app issue by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4685](https://togithub.com/dani-garcia/vaultwarden/pull/4685) - Fix duplicate folder creations during import by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4702](https://togithub.com/dani-garcia/vaultwarden/pull/4702) - Remove duplicate registry step by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4703](https://togithub.com/dani-garcia/vaultwarden/pull/4703) - add group support for Cipher::get_collections() by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/4592](https://togithub.com/dani-garcia/vaultwarden/pull/4592) - Switch registry cache compression algorithm to zstd by [@​dfunkt](https://togithub.com/dfunkt) in [https://github.com/dani-garcia/vaultwarden/pull/4704](https://togithub.com/dani-garcia/vaultwarden/pull/4704) - Update crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4714](https://togithub.com/dani-garcia/vaultwarden/pull/4714) - Some fixes for emergency access by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4715](https://togithub.com/dani-garcia/vaultwarden/pull/4715) #### New Contributors - [@​one230six](https://togithub.com/one230six) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4422](https://togithub.com/dani-garcia/vaultwarden/pull/4422) - [@​KrappRamiro](https://togithub.com/KrappRamiro) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4408](https://togithub.com/dani-garcia/vaultwarden/pull/4408) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4440](https://togithub.com/dani-garcia/vaultwarden/pull/4440) - [@​kristof-mattei](https://togithub.com/kristof-mattei) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4517](https://togithub.com/dani-garcia/vaultwarden/pull/4517) - [@​rich-purnell](https://togithub.com/rich-purnell) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4549](https://togithub.com/dani-garcia/vaultwarden/pull/4549) - [@​dfunkt](https://togithub.com/dfunkt) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4532](https://togithub.com/dani-garcia/vaultwarden/pull/4532) - [@​FDHoho007](https://togithub.com/FDHoho007) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/4500](https://togithub.com/dani-garcia/vaultwarden/pull/4500) **Full Changelog**: dani-garcia/vaultwarden@1.30.5...1.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mail is disabled instead of accepting emergency access for all invited users automatically, we only accept the emergency access invitation immediately if the user already exists and has a
password_hash. For invited users any open emergency access invitations will be accepted on registration.Also prevent invited emergency access contacts to register if emergency access is disabled (this is only relevant for when mail is enabled, if mail is disabled they would have an Invitation entry).
This should address the issue reported in #3183 without any breaking changes (i.e. this will not disable the emergency access feature when mail is disabled).