Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take ROCKET_ADDRESS into account in the Docker healthcheck #2844

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Take ROCKET_ADDRESS into account in the Docker healthcheck #2844

merged 1 commit into from
Oct 20, 2022

Conversation

jjlin
Copy link
Contributor

@jjlin jjlin commented Oct 20, 2022 •
edited
Loading

Fixes #2841.

@jjlin jjlin mentioned this pull request Oct 20, 2022
Closed
@dani-garcia dani-garcia merged commit 4cb5122 into dani-garcia:main Oct 20, 2022
@jjlin jjlin deleted the healthcheck branch October 20, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackDex BlackDex BlackDex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using a custom ROCKET_ADDRESS value results in erroneously reporting container as "Unhealthy" (healthcheck.sh)
3 participants
@jjlin @BlackDex @dani-garcia