Add a persistent volume check.

[BlackDex]

This will add a persistent volume check to make sure when running
containers someone is using a volume for persistent storage.

This check can be bypassed if someone configures
I_REALLY_WANT_VOLATILE_STORAGE=true as an environment variable.

This should prevent issues like #2493 .

[williamdes]

I am not convinced reading the diff on how it does work, can you explain a bit more ?

[BlackDex]

I am not convinced reading the diff on how it does work, can you explain a bit more ?

Within the container it creates a special file. This special file is checked within the code. If this file exists then Vaultwarden will exit.

That file should disappear if docker mounts over the data folder, and hence that file should be gone.

[williamdes]

I am not convinced reading the diff on how it does work, can you explain a bit more ?

Within the container it creates a special file. This special file is checked within the code. If this file exists then Vaultwarden will exit.

That file should disappear if docker mounts over the data folder, and hence that file should be gone.

Aha !
Maybe just add one more comment line that says something like "The /data/ volume will remove this file and this is proves persistence is setup"

[BlackDex]

I am not convinced reading the diff on how it does work, can you explain a bit more ?

Within the container it creates a special file. This special file is checked within the code. If this file exists then Vaultwarden will exit.
That file should disappear if docker mounts over the data folder, and hence that file should be gone.

Aha ! Maybe just add one more comment line that says something like "The /data/ volume will remove this file and this is proves persistence is setup"

Done :)

[williamdes]

Perfect, missing Dockerfile updates from template but okay :)

[BlackDex]

Meh forgot to run make. Will do that later