Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation insondistency concerning websocket notifications #3630

Closed
sheerun opened this issue Jul 1, 2023 · 3 comments
Closed

Documentation insondistency concerning websocket notifications #3630

sheerun opened this issue Jul 1, 2023 · 3 comments

Comments

@sheerun
Copy link

sheerun commented Jul 1, 2023

https://github.com/dani-garcia/vaultwarden/wiki/Enabling-WebSocket-notifications

It says "Note: The reason for this workaround is the lack of support for WebSockets from Rocket (though it's a planned feature), which forces us to launch a secondary server on a separate port."

I think it is not up do date because "it's a planned feature" links to rwf2/Rocket#90 which is closed

@BobWs
Copy link

BobWs commented Jul 2, 2023

This was added to the wiki a long time ago...

@JeDaYoshi
Copy link

It also doesn't mention that WebSocket support was directly added to the Rocket server.
However, it's currently only on beta, not on a stable release - although seems to be working well for me.

@ShlomiD83
Copy link

Hi all,
If I use WS on port 80 my chrome extension doesn't seem to update automatically.
If I use port 3012 everything works.

What am I doing wrong?

Repository owner locked and limited conversation to collaborators Jul 3, 2023
@BlackDex BlackDex converted this issue into discussion #3638 Jul 3, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants