Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media download by updating dependencies #32

Merged
merged 5 commits into from
Mar 12, 2022

Conversation

danguilherme
Copy link
Owner

@danguilherme danguilherme commented Jul 23, 2020

PR Details

Upgrade dependencies.

Description

  • highland: 2.11.1 => 2.13.0
  • left-pad: 1.1.3 => 1.3.0
  • spotify-web-api: 2.3.5 => 5.0.2
  • youtube-api: 2.0.2 => 3.0.1
  • ytdl-core: 3.1.2 => 4.11.0

Related Issue

Fixes #12

- use Yarn instead of npm
@danguilherme
Copy link
Owner Author

Needs testing.

@Eithoo
Copy link

Eithoo commented Dec 9, 2020

Spotivy wasn't working after installation - there were problems with ytdl-core. I changed version manually to the newest (4.1.4) and now it's working how it's supposed to work. Im kinda new on github and I don't know how to apply that change here, so I'm writing here 😄

@danguilherme
Copy link
Owner Author

Hey @Eithoo, thanks for the heads up!

I think I can do it now, the other dependency I was waiting on seems to be resolved.
I'll do this as soon as possible. I can't test it extensively, but will do a quick check to make sure everything works as expected.

@osanchez25
Copy link

Hi , any news on updating this. I tried to make this work but was unable to do it.

- spotify-web-api-node to v5.0.2
- youtube-api to v3.0.1
- ytdl-core to v4.11.0
@danguilherme
Copy link
Owner Author

Also fixes #35

@danguilherme danguilherme marked this pull request as ready for review March 12, 2022 12:30
@danguilherme danguilherme changed the title Update dependencies Fix media download by updating dependencies Mar 12, 2022
@danguilherme danguilherme merged commit 3dc7747 into master Mar 12, 2022
@danguilherme danguilherme deleted the feature/update-dependencies branch March 12, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependencies
3 participants