Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoodMusicVideoContent criteria #8

Closed
danicuki opened this issue Dec 14, 2017 · 1 comment
Closed

GoodMusicVideoContent criteria #8

danicuki opened this issue Dec 14, 2017 · 1 comment

Comments

@danicuki
Copy link

the criterion you use to consider a music video good is somehow weak. I suggest that you warn the users in the documentation that there is no certainty that the correct song will be download. What do you think?

spotivy/youtube_search.js

Line 76 in 54a1a2d

function isGoodMusicVideoContent(videoSearchResultItem) {

@danguilherme
Copy link
Owner

I totally agree!
In the Spotivy release article I covered that (only in portuguese for now), but this information would be useful in the README, no doubt.

Also, any suggestion to improve the "what is a good music video" algorithm is welcome!

danguilherme added a commit that referenced this issue Dec 17, 2017
@danguilherme
Improve README
5caeb1e 
- Link suggestions about what video to download to issue #8
@danguilherme danguilherme pinned this issue Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danicuki @danguilherme