Skip to content

Commit

Permalink
fix(typing): add missing ... for some overloads
Browse files Browse the repository at this point in the history
Spotted while testing a solution for [comment](vega#3426 (comment)).

This isn't a solution for that, but ensures the overloads solve correctly.
  • Loading branch information
dangotbanned committed Jun 18, 2024
1 parent 88fbd11 commit bd949a9
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions altair/utils/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class MaxRowsError(Exception):
@overload
def limit_rows(data: None = ..., max_rows: Optional[int] = ...) -> partial: ...
@overload
def limit_rows(data: DataType, max_rows: Optional[int]) -> DataType: ...
def limit_rows(data: DataType, max_rows: Optional[int] = ...) -> DataType: ...
def limit_rows(
data: Optional[DataType] = None, max_rows: Optional[int] = 5000
) -> Union[partial, DataType]:
Expand Down Expand Up @@ -226,10 +226,10 @@ def to_json(
@overload
def to_json(
data: DataType,
prefix: str,
extension: str,
filename: str,
urlpath: str,
prefix: str = ...,
extension: str = ...,
filename: str = ...,
urlpath: str = ...,
) -> _ToFormatReturnUrlDict: ...


Expand Down Expand Up @@ -264,10 +264,10 @@ def to_csv(
@overload
def to_csv(
data: NonGeoDataType,
prefix: str,
extension: str,
filename: str,
urlpath: str,
prefix: str = ...,
extension: str = ...,
filename: str = ...,
urlpath: str = ...,
) -> _ToFormatReturnUrlDict: ...


Expand Down

0 comments on commit bd949a9

Please sign in to comment.