Skip to content

Commit

Permalink
test: Rename test to more specific `chart_error_example__four_errors_…
Browse files Browse the repository at this point in the history
…hide_fourth` (vega#3546)

Working on a different branch I had to track down the comment explaining that this should display only 3 errors.
The original name lead me to expect 4 errors
  • Loading branch information
dangotbanned authored Aug 19, 2024
1 parent c7e1e83 commit 591bf40
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/utils/test_schemapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ def chart_error_example__two_errors_with_one_in_nested_layered_chart():
return chart


def chart_error_example__four_errors():
def chart_error_example__four_errors_hide_fourth():
# Error 1: unknown is not a valid encoding channel option
# Error 2: Invalid Y option value "asdf".
# Error 3: another_unknown is not a valid encoding channel option
Expand Down Expand Up @@ -821,7 +821,7 @@ def id_func(val) -> str:
r"""'1' is an invalid value for `value`. Valid values are of type 'object', 'string', or 'null'.$""",
),
(
chart_error_example__four_errors,
chart_error_example__four_errors_hide_fourth,
r"""Multiple errors were found.
Error 1: `Color` has no parameter named 'another_unknown'
Expand Down

0 comments on commit 591bf40

Please sign in to comment.