#80 Fix and sample multihtmldoc pdf #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sample testdriver how to use multiple HTML documents for one PDF. I also fixed a bug with bookmarks related to multiple HTML documents in one PDF.
The bookmark-markup is very special and esoteric (i.e. non-standard). But at least it works now again. No idea if we should let it be as it is, or come up with something more standard... Also requiring the bookmarks in the header is rather difficult if you only know the content at the end of the document...
Should PdfBoxRenderer::createPDFWithoutClosing() stay public, or should we try to hide it with the builder? i.e. as a builder option? This would also help the user discovering this feature.