Testcase and fix for rotation on the second and following pages. #171
Conversation
We must add the previous vertical page margins. The testcase is also an example for a more complicated report table.
the state. Otherwise we might have an inbalanced save / restore. (Which Acrobat Reader really does not like, but the macOS Preview application does not care...)
…ke sharing Resources of XForm's ...
|
G’day @rototor I’m not sure we can just use save/restore graphics as it is also in use for clip/setClip. The problem is that these may be out of order, for example: This was why I came up with the convoluted system of inverse transforms and reapplying transforms in effect after a setClip call. Ideally, we could guarantee that clip/setClip and pushtransforms/poptransforms are only called in correct order, but I found the clipping system to be complex enough to make this difficult. Incidentally, save/restore is the only way to implement setClip. |
|
@danfickle Ok, I restored the old behavior and removed the call to save/restore from the transform stuff. |
|
Thanks @rototor Looks good. |
We must add the previous vertical page margins.
The test case is also an example for a more complicated report table.
Also renamed setPdfMatrix to applyPdfMatrix, because it's not a replacement of the matrix but rather a addition to the current matrix. And we can spare the applying of the reverse matrix in the PDF case, as we can just saveGraphics()/restoreGraphics().