Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline seems to not take space expansion into account #281

Closed
koritakoa opened this issue Oct 8, 2018 · 2 comments
Closed

Underline seems to not take space expansion into account #281

koritakoa opened this issue Oct 8, 2018 · 2 comments

Comments

@koritakoa
Copy link

In a paragraph with 'text-align: justify', I have a span that is underlined. The line does not extend to the full width of the span. About 1.8 characters at the end are not underlined. I think this is due to the span being expanded in width due to the justified alignment.

0.0.1-RC15

danfickle added a commit that referenced this issue Oct 8, 2018
It turns out we were adjusting the x coordinate of affected boxes but not their width.
@danfickle
Copy link
Owner

Hi @koritakoa,

Yes, you were right. We were adjusting the position of the enclosing boxes but not their width.

Before:
issue-281-before

After:
issue-281-after

I think I can close this now. Thanks for reporting. I wish all bugs were as easy to find!

@koritakoa
Copy link
Author

Thank you for resolving this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants