Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up user agents and usages of user agents #18

Closed
4 of 5 tasks
danfickle opened this issue Apr 2, 2016 · 1 comment
Closed
4 of 5 tasks

Clean up user agents and usages of user agents #18

danfickle opened this issue Apr 2, 2016 · 1 comment
Labels
java2d-work-needed

Comments

@danfickle
Copy link
Owner

danfickle commented Apr 2, 2016 •
edited
Loading

This comprises the following tasks:

  • Implement pluggable URI resolver.
  • Implement pluggable cache.
  • Make sure all calls for external resources go through the user agent. Specifically: URI resolver -> cache -> http stream.
  • Allow vetoing of an external resource call, probably with the URI resolver.
  • Allow overriding of the whole user agent.
danfickle added a commit that referenced this issue Apr 2, 2016
@danfickle
For #18 - Implement pluggable URI resolver and pluggable cache for th…
327a5e2 
…e naive user agent used by the pdf renderer.

Note: The Java2D renderer used by the browser example uses its own user
agent so will not be covered by this commit.
danfickle added a commit that referenced this issue Apr 5, 2016
@danfickle
For #18 - Further work on the pluggable URI resolver and cache. Also,…
89ff4ff 
… explanation in readme.
@danfickle
Copy link
Owner Author

It is not practical to override the entire user agent so closing this for now.

burka pushed a commit to burka/openhtmltopdf that referenced this issue Apr 26, 2024
@siegelzc @zachary-foreflight
Miscellaneous changes following danfickle#17 (danfickle#18)
b869c26 
* add .DS_Store to .gitignore

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* add comment and warning message

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* change level to FINE and add comment

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* formatting

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* formatting

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* dont overwrite StylesheetInfo URI with null for inline stylesheet

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* formatting

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* reduce "media = {}" log to FINE

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* set uri on default StylesheetInfo to classpath uri

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* formatting + multiplicative array capacity

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* tail recursion comment

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* fix typo in log message

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* consolidate parse call to getStylesheet(StylesheetInfo)

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* rename: push -> save

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* rename: t -> token

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* rename: la -> nextWithSave

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* remove confusing and useless prio() method

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* add comments for top-of-file at-rules

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>

* run the intellij formatter

* remove unused labels

* add myself to developer list

---------

Signed-off-by: Zachary Siegel <siegelzc@gmail.com>
Co-authored-by: Zachary Siegel <zachary@foreflight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
java2d-work-needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danfickle